Skip to content

Revise vm.max_map_count recommendation in bootstrap checks #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shainaraskas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revise vm.max_map_count recommendation in bootstrap checks #4447

shainaraskas wants to merge 1 commit into from
+1 −1

Conversation

@shainaraskas
Copy link
Collaborator

@shainaraskas shainaraskas commented Dec 23, 2025 •
edited
Loading

Summary

Updated the recommended value for vm.max_map_count to 1048576 in the bootstrap check docs

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@shainaraskas
Revise vm.max_map_count recommendation in bootstrap checks
e26058f 
Updated the recommended value for vm.max_map_count to 1048576.
@shainaraskas shainaraskas requested a review from a team as a code owner December 23, 2025 17:15
@shainaraskas shainaraskas requested a review from kunisen December 23, 2025 17:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

✅ Vale Linting Results

No issues found on modified lines!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

🔍 Preview links for changed docs

@kunisen
Copy link
Contributor

kunisen commented Dec 24, 2025

Thank you @shainaraskas for opening this one. I missed to find we also have one mention in bootstrap.

But this is not true yet - I am asking in this internal comment to ES dev about whether we should change our bootstrap code to set it higher.

Currently it's still 262144 in ES code, so technically it means our bootstrap value is not bumped yet.

We are waiting on @mark-vieira and other ES team to confirm they want to carry out this change too, and if so, then we will likely have the value reflected to latest 8.18, 8.19 (as IIUC both minors are under maintenance) and 9.x docs.

I don't have a good idea about what we should do to this PR, but maybe we could wait until ES dev friend comes back after holiday season and discuss together? WDYT?

kunisen
kunisen requested changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@kunisen kunisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some quick comments and set it to "Request changes" to make sure we have a clear direction before merging it. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kunisen kunisen kunisen requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shainaraskas @kunisen